Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta): Added the test case for verify BGP peer group of the BGP IPv4 peer(s) #815

Merged
merged 17 commits into from
Jan 14, 2025
Merged

feat(anta): Added the test case for verify BGP peer group of the BGP IPv4 peer(s) #815

merged 17 commits into from
Jan 14, 2025

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Verifies BGP peer group of the BGP IPv4 peer(s).

Expected Results
----------------
* Success: The test will pass if the peer group is correctly assigned to the BGP peer(s).
* Failure: The test will fail if the BGP peer group not correctly assigned or peer is not configured.

Fixes #810

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

MaheshGSLAB
MaheshGSLAB reviewed Sep 6, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

MaheshGSLAB
MaheshGSLAB reviewed Sep 24, 2024
View reviewed changes
MaheshGSLAB
MaheshGSLAB reviewed Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the pre-commit by disable the line warning issue

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 7, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #815 will not alter performance

Comparing vitthalmagadum:issue_810 (98ad244) with main (56acfbc)

Summary

✅ 22 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

gmuloc
gmuloc previously requested changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting change to block merging until this is updated to new format for inputs

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

carl-baillargeon
carl-baillargeon approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes.

@gmuloc gmuloc dismissed their stale review January 14, 2025 16:01

comment addressed

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gmuloc gmuloc merged commit 35f246f into aristanetworks:main Jan 14, 2025
25 checks passed
geetanjalimanegslab pushed a commit to geetanjalimanegslab/anta that referenced this pull request Jan 15, 2025
@vitthalmagadum @gmuloc
@carl-baillargeon @geetanjalimanegslab
feat(anta): Added the test case for verify BGP peer group of the BGP …
a8c5c39 
…IPv4 peer(s) (aristanetworks#815)

* issue_810 Added TC for BGP peer-group

* issue_810 Handling review comments: updated failure messages

* CI fixes after conflicts removal

* issue_810 Handling review comment: update new line

* issue_810 Added pylint disable check for no of line

* Updated input model changes and unit tests for input

* Minor fixes

* Minor fixes

---------

Co-authored-by: VitthalMagadum <[email protected]>
Co-authored-by: gmuloc <[email protected]>
Co-authored-by: Carl Baillargeon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@gmuloc gmuloc Awaiting requested review from gmuloc

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: feat(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the test case to verify BGP peer group
4 participants
@vitthalmagadum @gmuloc @carl-baillargeon @MaheshGSLAB